Add jar as a valid value for artifact type#3367
Merged
shreyas-goenka merged 1 commit intomainfrom Aug 6, 2025
Merged
Conversation
shreyas-goenka
requested review from
andrewnester,
anton-107,
denik and
pietern
as code owners
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
24 failing tests:
|
denik
approved these changes
Aug 6, 2025
alyssa-db
pushed a commit
that referenced
this pull request
Aug 7, 2025
## Why While settings `type: jar` is non-functional, it is a value we have documented in our docs. So we should keep it around as a valid value. ## Tests n/a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
While settings
type: jaris non-functional, it is a value we have documented in our docs. So we should keep it around as a valid value.Tests
n/a